-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Narayana 6.0.0.CR1 in the Jakarta branch #30475
Comments
/cc @manovotn (jakarta), @maxandersen (jakarta), @mmusgrov (narayana), @radcortez (jakarta), @Sanne (jakarta) |
these coordinate changes seemed to work fine in Hibernate ORM: @mmusgrov any other transitive dependencies we should be mindful of? |
Actually, that previous commit failed non-core integration tests; this should work: |
/cc @manovotn (jakarta), @maxandersen (jakarta), @mmusgrov (narayana), @radcortez (jakarta), @Sanne (jakarta) |
@Sanne The JTA spec API only specifies two dependencies: |
thanks @mmusgrov , but yes I was asking about the Narayana dependencies: we can ignore the build time and test dependencies, but for each of the runtime dependencies we will need them aligned to the BOM in Quarkus - especially in case other components might depend on the same. Sometimes there is more flexibility, other times you might need a very specific version, so it would be great if the owning team could provide some guidance beyond the content of the pom files. Incidentally, the pom files seem incomplete as well as I had to manually pull in the CDI and Jakarta Interceptor APIs; if these are required I would expect them to be declared as transitive dependencies of Narayana. |
@Sanne I made a local fix and built
the build fails with How do I tell grade to look in my local repo when resolving 6.0.0.Final-SNAPSHOT? |
Found it (I needed to include mavenLocal() in the dependencyResolutionManagement section of settings.gradle). I'll update 6.0.0.Final-SNAPSHOT with the missing transitive dependencies so the fix will appear when we release 6.0.0.Final. Regarding your other comment about aligning Narayana dependencies with versions as specified in the Quarkus BOM. Are you referring to versions of Jakarta dependencies that Narayana and Quarkus share or more than just those. |
Right, exactly that. Thanks!
I'm referring to any dependency that Naryana will require: including Jakarta APIs but not only. If there's anything in the Quarkus BOM that you know needs to be strictly aligned with Narayana needs. In general we can rely on integration tests, but since integration testing doesn't have as high coverage as Narayana's own testsuite, it might be best for you to occasionally have a look - especially if you know of strict expectations, such as cases in which you had to upgrade a dependency to a particular version to fix/avoid some issues. Sometimes the opposite is true as well; for example I just upgraded Hibernate ORM's dependencies to match some newer versions of dependencies that Quarkus is using. Then when all dependencies are aligned we have the reassurance of both integration testsuites; or in this case we have the benefit of all three integration testsuites converging, since I upgraded Hibernate ORM to Narayana 6.0.0.CR1 as well ;) |
Thanks @Sanne we have started working on a narayana bom (narayana pr/2079) which will help us with aligning dependencies. Regarding the transitive dependency issue; we already include I also created a small JTA transaction example [2] whose pom only pulls in [1] https://github.com/jbosstm/narayana/blob/main/ArjunaJTA/narayana-jta/pom.xml#L135
|
thanks @mmusgrov , the failures of Hibernate ORM's integration tests are triggered when we run it on the modules path; but let's not digress too much about that here as this is the Quarkus PR - I was just letting you know, as Narayana end users might benefit from those dependencies being included, but it's not essential to Quarkus. Thanks for the link to the pom file - I'll use that to check alignment with Quarkus and send subsequent PRs as (and if) needed. |
@mmusgrov I found a single dependency misaligned - not sure how important it is: Narayana has a dependency to |
My guess is that we will have to tweak the rewrite rules to go back to the standard artifacts which should be Jakarta-enabled now.
The text was updated successfully, but these errors were encountered: