Inline Log category property doesn't work

[pjgg]

Describe the bug

Quarkus 2.15.0.Final

I am trying to set quarkus.log.category property through an inline system property at start time (Quarkus Dev Mode)

mvn quarkus:dev -Dquarkus.log.category."io.quarkus".level=WARN or

mvn quarkus:dev -Dquarkus.log.category.\"io.quarkus\".level=WARN

But looks like the property is ignored. Works If I add the property to the application.property

This issue has an impact on the developer user experience

Expected behavior

log level for io.quarkus package should be "warning".

Actual behavior

log level for io.quarkus is not changed

How to Reproduce?

quarkus create app org.acme:getting-started \
    --extension='resteasy-reactive'

cd getting-started

mvn quarkus:dev -Dquarkus.log.category."io.quarkus".level=WARN

Result:

2023-01-10 09:45:36,125 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.log.category.io.quarkus.level" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo

Output of uname -a or ver

Linux fedora 6.0.16-300.fc37.x86_64

Output of java -version

openjdk 17.0.5 2022-10-18

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

FYI: @llowinge

[geoand]

The proper way to do this is to use: mvn quarkus:dev -Dquarkus.log.category.\"io.quarkus\".level=WARN (and it's mentioned in the logging guide)

This will result in the proper logging configuration, but it will print a false positive about an unused property - @radcortez this part should probably be addressed

[radcortez]

I'll have a look

[radcortez]

This will result in the proper logging configuration, but it will print a false positive about an unused property - @radcortez this part should probably be addressed

This is caused by the system properties being propagated by the DevMojo plugin. The parser code removes the quotes here:

quarkus/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/options/BootstrapMavenOptions.java

Line 58 in 8398d79

args = CommandLineUtils.translateCommandline(cmdLine);

And set it up here:

quarkus/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java

Line 1210 in 25c96c3

private void propagateUserProperties(MavenDevModeLauncher.Builder builder) {

Results in the command line:

[DEBUG] Launching JVM with command line: /Users/radcortez/.sdkman/candidates/java/11.0.14-tem/bin/java -Xverify:none -Dquarkus-internal.serialized-app-model.path=/Users/radcortez/Code/personal/quarkus-playground/services/number-api/target/quarkus/bootstrap/dev-app-model.dat -javaagent:/Users/radcortez/.m2/repository/io/quarkus/quarkus-class-change-agent/999-SNAPSHOT/quarkus-class-change-agent-999-SNAPSHOT.jar -Dhttps.protocols=TLSv1.1,TLSv1.2 -Dquarkus.log.category.io.quarkus.level=DEBUG -XX:TieredStopAtLevel=1 -agentlib:jdwp=transport=dt_socket,address=localhost:5005,server=y,suspend=n -Djava.util.logging.manager=org.jboss.logmanager.LogManager -jar /Users/radcortez/Code/personal/quarkus-playground/services/number-api/target/number-api-dev.jar
Listening for transport dt_socket at address: 5005

Without the quotes.

It ends up working because the properties are correctly propagated in:

quarkus/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java

Lines 68 to 72 in ee14de7

	for (Map.Entry<String, String> i : context.getSystemProperties().entrySet()) {
	if (!System.getProperties().containsKey(i.getKey())) {
	System.setProperty(i.getKey(), i.getValue());
	}
	}

So we get one quoted property and an unquoted property in System properties, which causes the warning.

I wonder if we need to propagate the properties in the java process since the DevModeContext is already doing this. Maybe other cases require it.

@aloubyansky what do you think?

[aloubyansky]

Yes, it looks like there is an overlap.

[radcortez]

Are we ok to remove the plugin overlap and keep the DevModeContext one?

[aloubyansky]

I did that in my branch and it passed the CI. I guess so.

[aloubyansky]

Here is what I tested aloubyansky@611b3de

[radcortez]

Yes. Feel free to send a PR, or I can also do it.

[aloubyansky]

I wanted to add a test based on this report but it appears to be tricky the way our tests are launched. I guess I'll just open a PR, we do have tests for passing -Dxxx args.