Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi tenancy column discriminator #28644

Closed
guitcastro opened this issue Oct 17, 2022 · 5 comments
Closed

Support for multi tenancy column discriminator #28644

guitcastro opened this issue Oct 17, 2022 · 5 comments
Labels
area/hibernate-orm Hibernate ORM kind/enhancement New feature or request

Comments

@guitcastro
Copy link

Description

#5681 added support to hibernate, however the column discriminator was not supported, because by the time, Hibernate itself didn't have fully support for it.


        if (multiTenancyStrategy == MultiTenancyStrategy.DISCRIMINATOR) {
            // See https://hibernate.atlassian.net/browse/HHH-6054
            throw new ConfigurationException("The Hibernate ORM multitenancy strategy "
                    + MultiTenancyStrategy.DISCRIMINATOR + " is currently not supported");
        }

However, HHH-6054 is now completed and we can have support for discriminator column.

Implementation ideas

No response

@guitcastro guitcastro added the kind/enhancement New feature or request label Oct 17, 2022
@geoand geoand changed the title Support for multi tenantcy column discriminator Support for multi tenancy column discriminator Oct 18, 2022
@geoand geoand added area/hibernate-orm Hibernate ORM and removed triage/needs-triage labels Oct 18, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2022

/cc @Sanne, @gsmet, @yrodiere

@yrodiere
Copy link
Member

To clarify context: HHH-6054 is only fixed in Hibernate ORM 6, and Steve has stated pretty clearly it won't be backported to Hibernate ORM 5.

Quarkus (as much of the Java ecosystem, unfortunately) is still on ORM 5, because ORM 5 uses older Java EE packages (javax.persistence.*) while ORM 6 uses Jakarta EE packages (jakarta.persistence.*), so upgrading is a rather intrusive change.

Thus, support for discriminator-based multi-tenancy will happen, but only in Quarkus 3, which will upgrade to Hibernate ORM 6.

@guitcastro
Copy link
Author

Linking 26986 for reference.

@humcqc
Copy link
Contributor

humcqc commented Apr 24, 2023

Linking 32686 for reference, WIP.

humcqc added a commit to humcqc/quarkus that referenced this issue Apr 24, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 29, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 29, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 29, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 30, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 30, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 30, 2023
humcqc added a commit to humcqc/quarkus that referenced this issue Apr 30, 2023
yrodiere pushed a commit to humcqc/quarkus that referenced this issue May 1, 2023
yrodiere pushed a commit to humcqc/quarkus that referenced this issue May 1, 2023
@yrodiere
Copy link
Member

yrodiere commented May 1, 2023

Fixed by #32855

@yrodiere yrodiere closed this as completed May 1, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 2, 2023
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants