-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support quarkus.jib.jvm-entrypoint=INHERIT #28071
Comments
/cc @geoand |
We can't really support this, because we always need to point to the Quarkus jar. |
That's not true, currently I use this command:
I would like Quarkus to support this usage to inherit entrypoint from base image.
|
Interesting point. |
As you have already analyzed the code, would you like to take a shot at implementing your proposal? |
ok, let me try :-) |
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071 (cherry picked from commit 74290e4)
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
…ve-entrypoint jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it. Fixed quarkusio#28071
Description
https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin
Both jib-maven-plugin and jib-gradle-plugin support jib.container.entrypoint=INHERIT to inherit container entrypoint from base image, but quarkus-container-image-jib always overrides container entrypoint.
Implementation ideas
https://github.com/quarkusio/quarkus/blob/main/extensions/container-image/container-image-jib/deployment/src/main/java/io/quarkus/container/image/jib/deployment/JibProcessor.java#L382
When entrypoint is
["INHERIT"]
, calljibContainerBuilder.setEntrypoint(null).setProgramArguments(jibConfig.jvmArguments)
.The text was updated successfully, but these errors were encountered: