Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default config sources to codegen config #27431

Closed
jamesnetherton opened this issue Aug 23, 2022 · 1 comment · Fixed by #27436
Closed

Add default config sources to codegen config #27431

jamesnetherton opened this issue Aug 23, 2022 · 1 comment · Fixed by #27436
Labels
kind/enhancement New feature or request
Milestone
2.12.0.Final

Comments

@jamesnetherton
Copy link
Contributor

Description

Seems that the Config instance passed to the CodeGenProvider implementation does not have the default config sources configured. Therefore, if you need to resolve system properties, you're forced to look them up manually via System.getProperty.

It'd be nicer if you could resolve them automatically via the Config instance. It'd make overriding of config values via the command line a bit simpler to handle.

Implementation ideas

Add setAddDefaultSources(true) to the config builder in CodeGenerator.trigger().
@jamesnetherton jamesnetherton added the kind/enhancement New feature or request label Aug 23, 2022
geoand added a commit to geoand/quarkus that referenced this issue Aug 23, 2022
@geoand
Add system properties source to CodeGenerator config sources
1b87bab 
Resolves: quarkusio#27431
@geoand geoand mentioned this issue Aug 23, 2022
Merged
@geoand
Copy link
Contributor

geoand commented Aug 23, 2022

#27436 takes care of it

gsmet added a commit that referenced this issue Aug 23, 2022
@gsmet
Merge pull request #27436 from geoand/#27431
7e8847c 
Add system properties source to CodeGenerator config sources
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 23, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.0.Final Aug 23, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 23, 2022
@geoand @gsmet
Add system properties source to CodeGenerator config sources
b68d258 
Resolves: quarkusio#27431
(cherry picked from commit 1b87bab)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 24, 2022
@geoand @gsmet
Add system properties source to CodeGenerator config sources
9c4a92c 
Resolves: quarkusio#27431
(cherry picked from commit 1b87bab)
fercomunello pushed a commit to fercomunello/quarkus that referenced this issue Aug 31, 2022
@geoand @fercomunello
Add system properties source to CodeGenerator config sources
ef41b1e 
Resolves: quarkusio#27431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
2.12.0.Final
Development

Successfully merging a pull request may close this issue.

Add system properties source to CodeGenerator config sources geoand/quarkus
3 participants
@gsmet @geoand @jamesnetherton