-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resteasy Reactive Client: Parameter "annotations" is always null in ParamConverterProvider #22870
Labels
Milestone
Comments
@Sgitario you might be interested in this one. |
@geoand Will this be fixed in Quarkus 2.7.0 ? |
Not sure, we have a lot to get done for |
Added to my TODO list. |
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Jan 21, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Jan 22, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Jan 27, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Jan 31, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Feb 1, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Feb 4, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Feb 4, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Feb 7, 2022
Note that this PR will introduce a performance penalty at load time (first time, when the rest client instance is loaded AND if and only if the rest client methods use param annotations - which is most of the times tho). What I did was to always generate the `javaMethodX` static fields (before, it was also generated always, but it was done in the implementation MicroProfileRestClientEnricher). Plus, apart of the method information, we will also load the annotations and the generic types. This is done at load class time (static init). Moreover, as I had to move some code from MicroProfileRestClientEnricher to JaxrsClientReactiveProcessor, in order to not increase the length of this class JaxrsClientReactiveProcessor, I started moving some code to ClassRestClientContext (which is protected - not available for users) Fix quarkusio#22870 (cherry picked from commit 7f453ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The parameter
annotations
inParamConverterProvider
is always null.Expected behavior
No response
Actual behavior
No response
How to Reproduce?
Output of
uname -a
orver
No response
Output of
java -version
Java 11
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.6.2
Build tool (ie. output of
mvnw --version
orgradlew --version
)Maven
Additional information
No response
The text was updated successfully, but these errors were encountered: