Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The configuration item quarkus.native.container-runtime will cause the configuration item quarkus.native.container-build=false to be invalid #20258

Closed
lost22git opened this issue Sep 19, 2021 · 2 comments · Fixed by #20517
Closed

The configuration item quarkus.native.container-runtime will cause the configuration item quarkus.native.container-build=false to be invalid #20258

lost22git opened this issue Sep 19, 2021 · 2 comments · Fixed by #20517
Labels
area/native-image kind/bug Something isn't working
Milestone
2.4.0.CR1

Comments

@lost22git
Copy link

Describe the bug

application.properties

image

image

image

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

windows10

Output of java -version

11

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.2.2-final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@lost22git lost22git added the kind/bug Something isn't working label Sep 19, 2021
@quarkus-bot quarkus-bot bot added env/windows Impacts Windows machines triage/needs-triage labels Sep 19, 2021
@geoand
Copy link
Contributor

geoand commented Sep 20, 2021

Well, we need to pick on or the other - in this case we seem to picking the latter.

I guess we could make this an error though, WDYT @zakkak ?

@zakkak
Copy link
Contributor

zakkak commented Sep 20, 2021 •
edited
Loading

Well, we need to pick on or the other - in this case we seem to picking the latter.

I guess we could make this an error though, WDYT @zakkak ?

If I recall correctly the reasoning behind this was that if you are setting container-runtime then you probably are interested in using a container to build the native image. I can see however that someone might have this set in the application properties file while experimenting with -Dquarkus.native.container-build=false on the command line.

I would personally prefer honoring container-build and throwing a warning (if necessary) instead of an error, but I think Quarkus users are more suitable to answer this :)

@zakkak zakkak added area/native-image and removed env/windows Impacts Windows machines labels Oct 4, 2021
zakkak added a commit to zakkak/quarkus that referenced this issue Oct 4, 2021
@zakkak
Makes container-runtime=true not imply container-build=true
af07961 
Makes -Dquarkus.native.container-runtime=true not imply
-Dquarkus.native.container-build=true and respect the value of the
latter. Additionally makes isContainerBuild checks consistent.

I.e. if -Dquarkus.native.container-runtime=true
-Dquarkus.native.container-build=false are passed as parameters Quarkus
will not use a builder image.

Closes: quarkusio#20258
@zakkak zakkak mentioned this issue Oct 4, 2021
Merged
zakkak added a commit to zakkak/quarkus that referenced this issue Oct 5, 2021
@zakkak
Honor explicit container-build=false when container-runtime is set
8d2d6d3 
Makes -Dquarkus.native.container-runtime=docker not imply
-Dquarkus.native.container-build=true when the latter is explicitly set
to false.  Additionally makes isContainerBuild checks consistent.

I.e. if -Dquarkus.native.container-runtime=podman
-Dquarkus.native.container-build=false are passed as parameters Quarkus
will not use a builder image.

Closes: quarkusio#20258
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/native-image kind/bug Something isn't working
Projects
None yet
Milestone
2.4.0.CR1
Development

Successfully merging a pull request may close this issue.

Honor explicit container-build=false when container-runtime is set zakkak/quarkus
3 participants
@zakkak @geoand @lost22git