Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive rest client custom exception mapper is invoked twice #19476

Closed
mkonzal opened this issue Aug 18, 2021 · 2 comments · Fixed by #19498
Closed

Reactive rest client custom exception mapper is invoked twice #19476

mkonzal opened this issue Aug 18, 2021 · 2 comments · Fixed by #19498
Assignees
Labels
area/rest-client kind/bug Something isn't working
Milestone

Comments

@mkonzal
Copy link

mkonzal commented Aug 18, 2021

Describe the bug

When I register my custom exception mapper to a client wit @RegisterProvider then the both methods of ResponseExceptionMapper<T> are invoked twice.

Expected behavior

The invocation is done just once.

Actual behavior

No response

How to Reproduce?

Reproducer: https://github.com/mkonzal/quarkus-reactive-response-exception-mapper.git

Step to reproduce GET /service/connect

Output of uname -a or ver

No response

Output of java -version

openjdk version "11.0.12" 2021-07-20 LTS

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.1.2

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)

Additional information

No response

@mkonzal mkonzal added the kind/bug Something isn't working label Aug 18, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 18, 2021

/cc @michalszynkiewicz

@michalszynkiewicz
Copy link
Member

The problem is in the fact that client response filters are invoked in the abort chain. I think we need to have a different abort chain, without them, if the filters execution has started. I'll try to create a PR for it

@michalszynkiewicz michalszynkiewicz self-assigned this Aug 19, 2021
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Aug 19, 2021
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Aug 20, 2021
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Aug 20, 2021
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Aug 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 24, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 24, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 24, 2021
@gsmet gsmet modified the milestones: 2.2.0.Final, 2.1.4.Final Aug 25, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 25, 2021
@gsmet gsmet modified the milestones: 2.1.4.Final, 2.2.0.Final Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest-client kind/bug Something isn't working
Projects
None yet
3 participants