Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusIntegrationTest docker env does not work with property names containing '/' #17810

Closed
bdevreugd-vialis opened this issue Jun 9, 2021 · 2 comments · Fixed by #17820
Closed
Assignees
Milestone

Comments

@bdevreugd-vialis
Copy link
Contributor

We use the GraphQLClient in Quarkus 2.0.0, it requires a property called test-service/mp-graphql/url.
When the docker image is started, it is started with param: --env TEST_SERVICE/MP_GRAPHQL/URL=http://localhost:50683
This is an invalid environment variable, so it fails.

This is caused by:

private String convertPropertyToEnVar(String property) {
return property.toUpperCase().replace('-', '_').replace('.', '_');
}

Please make sure it also converts '/' to '_'

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Jun 9, 2021 via email

geoand added a commit to geoand/quarkus that referenced this issue Jun 10, 2021
@geoand geoand self-assigned this Jun 10, 2021
geoand added a commit that referenced this issue Jun 10, 2021
Properly convert property to env var in @QuarkusIntegrationTest
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 10, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants