Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry: Distributed tracing with Reactive Routes #16520

Closed
pjgg opened this issue Apr 14, 2021 · 4 comments
Closed

Opentelemetry: Distributed tracing with Reactive Routes #16520

pjgg opened this issue Apr 14, 2021 · 4 comments

Comments

@pjgg
Copy link
Contributor

pjgg commented Apr 14, 2021

Description

As far as I see with reactive Routes (Vert.x) and openTelemetry we are not propagating trace headers between different microservices.

As a cloud-native developer, most of the applications are a composition of several microservices, distributed in several places, some of them are under our platform as ocp/k8s and some others are in third-party services (even in serverless platforms like Knative). So, for us is important to propagate the trace headers as traceId, ParentSpanId or spanId, in order to be able to understand why a given request takes "so much time" (because we would have one traceID and N spans as a tree, so we have all the dependencies, all the transaction history recorded).

Also would be great, be able to use a common protocol for all the layers (services), so if for example X-B3 is widely adopted because of Istio, then would be great to be able to enable/disbaled b3 headers with a property like: opentracing.jaeger.enable-b3-propagation=true

@pjgg pjgg added the kind/enhancement New feature or request label Apr 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 14, 2021

/cc @Ladicek, @geoand, @kenfinnigan

@kenfinnigan
Copy link
Member

As mentioned on #16499, Reactive Routes has not been tested with OpenTelemetry at present

@kenfinnigan kenfinnigan changed the title Opentelemetry: Distributed tracing Opentelemetry: Distributed tracing with Reactive Routes Jun 23, 2021
@kenfinnigan
Copy link
Member

@pjgg you could try this again with 2.0.0.CR3, as I think it should work now

@kenfinnigan
Copy link
Member

Also, specifying different context propagation is available in 2.0.0.Final.

I'm going to close as I've verified Reactive Routes is being traced, and we do inject headers into outgoing requests.

Please re-open with a reproducer if it's not the case

@kenfinnigan kenfinnigan added this to the 2.0.0.Final milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants