Opentelemetry - reactiveRoutes / vertx

[pjgg]

Describe the bug

I am working with opentelemetry extensions over a Quarkus application with Reactive routes:

       <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-opentelemetry</artifactId>
        </dependency>

        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-opentelemetry-exporter-jaeger</artifactId>
        </dependency>

When I am running my application in JVM mode my jaeger ServiceName is set to <<unset>> but on native mode is set to 300-quarkus-vertx-webclient (my app-module name), as you can see on my test

This is quite an inconvenience :)
But In my opinion, the root of the issue is that we are not allowed to set a jaeger service name by configuration, as we do in other extensions as opentracing (quarkus-smallrye-opentracing).

Opentraicing config

# Jaeger
quarkus.jaeger.service-name=my-custom-service-name
quarkus.jaeger.sampler-type=const
quarkus.jaeger.sampler-param=1
quarkus.log.console.format=%d{HH:mm:ss} %-5p traceId=%X{traceId}, parentId=%X{parentId}, spanId=%X{spanId}, sampled=%X{sampled} [%c{2.}] (%t) %s%e%n

[quarkus-bot]

/cc @kenfinnigan

[kenfinnigan]

There's a couple of factors at play here. One is that OpenTelemetry has not been tested with Reactive Routes yet, and likely won't because my understanding is in Quarkus 2.x it won't be a recommended approach anymore. And two, I haven't reached a point of adding much customization to the extensions yet

[kenfinnigan]

It's a problem with how Quarkus tests work that quarkus.application.name and quarkus.application.version are not set when running tests, but are set with Dev mode or a built Jar.

The solution is to add quarkus.application.name=300-quarkus-vertx-webclient to your application.properties in src/test/resources so it's only applied for testing.

[rsvoboda]

quarkus.application.name and quarkus.application.version are now propagated in tests too thanks to #24666