Merge pull request #35155 from phillip-kruger/dev-ui-remove-dev-services

Remove Old Dev UI: Core Dev Services
quarkusio · Aug 3, 2023 · f55273b · f55273b
2 parents 573b5dc + f5471f9
commit f55273b
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 102 deletions.
diff --git a/...t/src/main/java/io/quarkus/vertx/http/deployment/devmode/console/DevConsoleProcessor.java b/...t/src/main/java/io/quarkus/vertx/http/deployment/devmode/console/DevConsoleProcessor.java
@@ -50,7 +50,6 @@
 import io.quarkus.deployment.builditem.ShutdownContextBuildItem;
 import io.quarkus.deployment.console.ConsoleCommand;
 import io.quarkus.deployment.console.ConsoleStateManager;
-import io.quarkus.deployment.dev.devservices.DevServiceDescriptionBuildItem;
 import io.quarkus.deployment.ide.EffectiveIdeBuildItem;
 import io.quarkus.deployment.ide.Ide;
 import io.quarkus.deployment.logging.LoggingSetupBuildItem;
@@ -419,11 +418,6 @@ public void setupDevConsoleRoutes(
         }
     }
 
-    @BuildStep(onlyIf = { IsDevelopment.class })
-    public DevConsoleTemplateInfoBuildItem config(List<DevServiceDescriptionBuildItem> serviceDescriptions) {
-        return new DevConsoleTemplateInfoBuildItem("devServices", serviceDescriptions);
-    }
-
     @Record(ExecutionTime.RUNTIME_INIT)
     @Consume(LoggingSetupBuildItem.class)
     @BuildStep(onlyIf = IsDevelopment.class)

diff --git a/extensions/vertx-http/deployment/src/main/resources/dev-templates/index.html b/extensions/vertx-http/deployment/src/main/resources/dev-templates/index.html
@@ -18,12 +18,6 @@
                    <i class="fa fa-edit fa-fw"></i>
                    Config Editor</a>
                </p>
-               <p class="card-text">
-                   <a href="io.quarkus.quarkus-vertx-http/dev-services" class="badge badge-light">
-                       <i class="fa fa-toolbox fa-fw"></i>
-                       Dev Services
-                   </a>
-               </p>
            </div>
        </div>
    </div>

diff --git a/...ployment/src/main/resources/dev-templates/io.quarkus.quarkus-vertx-http/dev-services.html b/...ployment/src/main/resources/dev-templates/io.quarkus.quarkus-vertx-http/dev-services.html
diff --git a/extensions/vertx-http/deployment/src/test/java/io/quarkus/devui/DevServicesTest.java b/extensions/vertx-http/deployment/src/test/java/io/quarkus/devui/DevServicesTest.java
@@ -0,0 +1,28 @@
+package io.quarkus.devui;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import com.fasterxml.jackson.databind.JsonNode;
+
+import io.quarkus.devui.tests.DevUIBuildTimeDataTest;
+import io.quarkus.test.QuarkusDevModeTest;
+
+public class DevServicesTest extends DevUIBuildTimeDataTest {
+
+    @RegisterExtension
+    static final QuarkusDevModeTest config = new QuarkusDevModeTest().withEmptyApplication();
+
+    public DevServicesTest() {
+        super("devui");
+    }
+
+    @Test
+    public void testGetExtensions() throws Exception {
+        JsonNode devServicesResponse = super.getBuildTimeData("devServices");
+        Assertions.assertNotNull(devServicesResponse);
+        Assertions.assertTrue(devServicesResponse.isArray());
+    }
+
+}
diff --git a/...ests/devmode/src/test/java/io/quarkus/test/devconsole/DevConsoleDevServicesSmokeTest.java b/...ests/devmode/src/test/java/io/quarkus/test/devconsole/DevConsoleDevServicesSmokeTest.java