Merge pull request #16368 from geoand/rest-client-jackson-issue

Fix build issue when client and server RESTEasy Reactive jackson deps are used together
quarkusio · Apr 8, 2021 · d0e7f5b · d0e7f5b
2 parents 9abf774 + de96799
commit d0e7f5b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/...eactive/jackson/deployment/processor/ResteasyReactiveJacksonProviderDefinedBuildItem.java b/...eactive/jackson/deployment/processor/ResteasyReactiveJacksonProviderDefinedBuildItem.java
@@ -6,6 +6,6 @@
  * A BuildItem to mark that the server side jackson provider is defined.
  * If not "emitted" by any of the processors, the reactive rest client (if used) will add its own jackson provider
  */
-public class ResteasyReactiveJacksonProviderDefinedBuildItem extends MultiBuildItem {
+public final class ResteasyReactiveJacksonProviderDefinedBuildItem extends MultiBuildItem {
 
 }
diff --git a/...o/quarkus/rest/client/reactive/jackson/deployment/RestClientReactiveJacksonProcessor.java b/...o/quarkus/rest/client/reactive/jackson/deployment/RestClientReactiveJacksonProcessor.java
@@ -36,7 +36,7 @@ void additionalProviders(
             BuildProducer<AdditionalBeanBuildItem> additionalBean,
             BuildProducer<MessageBodyReaderBuildItem> additionalReaders,
             BuildProducer<MessageBodyWriterBuildItem> additionalWriters) {
-        if (jacksonProviderDefined != null && !jacksonProviderDefined.isEmpty()) {
+        if (!jacksonProviderDefined.isEmpty()) {
             return;
         }
         // make these beans to they can get instantiated with the Quarkus CDI configured Jsonb object

diff --git a/integration-tests/micrometer-prometheus/pom.xml b/integration-tests/micrometer-prometheus/pom.xml
@@ -36,6 +36,12 @@
             <artifactId>quarkus-resteasy-reactive-jackson</artifactId>
         </dependency>
 
+        <!-- Verify that the client can co-exist with the server -->
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-rest-client-reactive-jackson</artifactId>
+        </dependency>
+
         <!-- Verify extensions co-exist -->
         <dependency>
             <groupId>io.quarkus</groupId>
@@ -115,6 +121,19 @@
                 </exclusion>
             </exclusions>
         </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-rest-client-reactive-jackson-deployment</artifactId>
+            <version>${project.version}</version>
+            <type>pom</type>
+            <scope>test</scope>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-kubernetes-deployment</artifactId>