Always create a new HashMap when changing the immutable extension met…

…adata
quarkusio · Jul 19, 2021 · b0feb74 · b0feb74
1 parent 24e6793
commit b0feb74
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/...nt-projects/tools/devtools-common/src/main/java/io/quarkus/platform/tools/ToolsUtils.java b/...nt-projects/tools/devtools-common/src/main/java/io/quarkus/platform/tools/ToolsUtils.java
@@ -156,13 +156,9 @@ public static ExtensionCatalog resolvePlatformDescriptorDirectly(String bomGroup
                         }
 
                         final OriginPreference originPreference = new OriginPreference(1, 1, 1, ++memberIndex, 1);
-                        Map<String, Object> metadata = memberCatalog.getMetadata();
-                        if (metadata.isEmpty()) {
-                            metadata = new HashMap<>();
-                            ((JsonExtensionCatalog) memberCatalog).setMetadata(metadata);
-                        }
+                        Map<String, Object> metadata = new HashMap<>(memberCatalog.getMetadata());
                         metadata.put("origin-preference", originPreference);
-
+                        ((JsonExtensionCatalog) memberCatalog).setMetadata(metadata);
                         catalogs.add(memberCatalog);
                     }
                     catalog = JsonCatalogMerger.merge(catalogs);