Optimise the strategy we use to reset the classloader in the Common F…

…orkJoin ThreadPool
quarkusio · Jul 21, 2021 · ae9a634 · ae9a634
1 parent 3242590
commit ae9a634
Showing 1 changed file with 33 additions and 22 deletions.
diff --git a/core/deployment/src/main/java/io/quarkus/runner/bootstrap/ForkJoinClassLoading.java b/core/deployment/src/main/java/io/quarkus/runner/bootstrap/ForkJoinClassLoading.java
@@ -20,31 +20,42 @@ public class ForkJoinClassLoading {
      * Really we should just not use the common pool at all.
      */
     public static void setForkJoinClassLoader(ClassLoader classLoader) {
-        CountDownLatch allDone = new CountDownLatch(ForkJoinPool.getCommonPoolParallelism());
-        CountDownLatch taskRelease = new CountDownLatch(1);
-        for (int i = 0; i < ForkJoinPool.getCommonPoolParallelism(); ++i) {
-            ForkJoinPool.commonPool().execute(new Runnable() {
-                @Override
-                public void run() {
-                    Thread.currentThread().setContextClassLoader(classLoader);
-                    allDone.countDown();
-                    try {
-                        taskRelease.await();
-                    } catch (InterruptedException e) {
-                        log.error("Failed to set fork join ClassLoader", e);
+        final ForkJoinPool commonPool = ForkJoinPool.commonPool();
+
+        final int activeThreadCount = commonPool.getActiveThreadCount();
+
+        //The following approach is rather heavy, but there's good chances that there are actually no active threads,
+        //so skip it in this case.
+        //Additionally, if we can skip this this will prevent us from actually forcing to start all threads in the pool.
+        if (activeThreadCount > 0) {
+            //TODO we could theoretically improve this by using the system property java.util.concurrent.ForkJoinPool.common.threadFactory
+            //and force the common pool to register created threads so that we can reach and reset them.
+            CountDownLatch allDone = new CountDownLatch(ForkJoinPool.getCommonPoolParallelism());
+            CountDownLatch taskRelease = new CountDownLatch(1);
+            for (int i = 0; i < ForkJoinPool.getCommonPoolParallelism(); ++i) {
+                commonPool.execute(new Runnable() {
+                    @Override
+                    public void run() {
+                        Thread.currentThread().setContextClassLoader(classLoader);
+                        allDone.countDown();
+                        try {
+                            taskRelease.await();
+                        } catch (InterruptedException e) {
+                            log.error("Failed to set fork join ClassLoader", e);
+                        }
                     }
+                });
+            }
+            try {
+                if (!allDone.await(1, TimeUnit.SECONDS)) {
+                    log.error(
+                            "Timed out trying to set fork join ClassLoader, this should never happen unless something has tied up a fork join thread before the app launched");
                 }
-            });
-        }
-        try {
-            if (!allDone.await(1, TimeUnit.SECONDS)) {
-                log.error(
-                        "Timed out trying to set fork join ClassLoader, this should never happen unless something has tied up a fork join thread before the app launched");
+            } catch (InterruptedException e) {
+                log.error("Failed to set fork join ClassLoader", e);
+            } finally {
+                taskRelease.countDown();
             }
-        } catch (InterruptedException e) {
-            log.error("Failed to set fork join ClassLoader", e);
-        } finally {
-            taskRelease.countDown();
         }
     }
 }