Merge pull request #28118 from geoand/#28114

Ensure that @QuarkusIntegrationTest does not leave dangling processes
quarkusio · Sep 21, 2022 · 2c06dde · 2c06dde
2 parents 84f953c + 25cf7c6
commit 2c06dde
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/test-framework/common/src/main/java/io/quarkus/test/common/DefaultJarLauncher.java b/test-framework/common/src/main/java/io/quarkus/test/common/DefaultJarLauncher.java
@@ -165,6 +165,6 @@ public void includeAsSysProps(Map<String, String> systemProps) {
 
     @Override
     public void close() {
-        quarkusProcess.destroy();
+        LauncherUtil.destroyProcess(quarkusProcess);
     }
 }
diff --git a/test-framework/common/src/main/java/io/quarkus/test/common/DefaultNativeImageLauncher.java b/test-framework/common/src/main/java/io/quarkus/test/common/DefaultNativeImageLauncher.java
@@ -267,6 +267,6 @@ public void includeAsSysProps(Map<String, String> systemProps) {
 
     @Override
     public void close() {
-        quarkusProcess.destroy();
+        LauncherUtil.destroyProcess(quarkusProcess);
     }
 }
diff --git a/test-framework/common/src/main/java/io/quarkus/test/common/LauncherUtil.java b/test-framework/common/src/main/java/io/quarkus/test/common/LauncherUtil.java
@@ -110,7 +110,7 @@ private static void ensureProcessIsAlive(Process quarkusProcess) {
      * Try to destroy the process normally a few times
      * and resort to forceful destruction if necessary
      */
-    private static void destroyProcess(Process quarkusProcess) {
+    static void destroyProcess(Process quarkusProcess) {
         quarkusProcess.destroy();
         int i = 0;
         while (i++ < 10) {