Add SmallRye Stork service discovery #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cescoffier / @aureamunoz / @michalszynkiewicz would you mind taking a look through this and make sure everything looks ok (including the updated documentation on the README)? In the |
|
Wait @cescoffier / @aureamunoz / @michalszynkiewicz is stork supposed to work in native? When I tried to build native image on my machine with these changes I'm getting this: |
|
seems if i add <dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
</dependency>to my |
edeandrea
force-pushed
the
stork
branch
6 times, most recently
from
dadd459 to
3978b59
Compare
Bumps `quarkus.platform.version` from 2.8.3.Final to 2.9.0.Final. Updates `quarkus-bom` from 2.8.3.Final to 2.9.0.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.8.3.Final...2.9.0.Final) Updates `quarkus-maven-plugin` from 2.8.3.Final to 2.9.0.Final --- updated-dependencies: - dependency-name: io.quarkus.platform:quarkus-bom dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.quarkus.platform:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eric Deandrea <[email protected]>
|
Hi @michalszynkiewicz would you be able to take a quick look at this for me? |
|
I'm at a conference this week, I'll try. Please ping me on zulip if I won't do it before the weekend |
|
Oh its fine it can wait until next week! Enjoy the conference! |
|
Apoligies for the delay @edeandrea, Im in Devoxx UK and I have been working on the talk until now, I'll take a look |
|
No worries at all @aureamunoz! Go attend the conference and good luck on your talk! This can wait until after. |
aureamunoz
reviewed
May 12, 2022
There was a problem hiding this comment.
Globally LGTM. Is there a reason to not using the quarkus stork extension? And in that case, you should use the corresponding kubernetes client one for take advantage of all native staff around Kubernetes client (look at #24444)
|
LGTM
Thanks @edeandrea! just did a quick review ;-) |
|
Thanks @aureamunoz
Isn't this project using it? The guide makes no mention of any Quarkus specific extension. It just mentions the stork libraries. The The calls to
The |
|
@michalszynkiewicz / @aureamunoz for some reason my PR got all messed up when I tried to rebase |
Ah, this is why I now see 118 modified files? Before I though having only 16 |
Ok, my bad ! yes, the stork extension is used via the |
|
@michalszynkiewicz / @aureamunoz see #82 for the fixed PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SmallRye Stork service discovery for both the hero & villain services.
The
VillainClient, is implemented by directly using the JAX-RS client API with the RESTEasy Reactive client. Therefore, the Stork API is used directly in order to get the same functionality available in theHeroRestClient.Fixes #40