Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pact contract testing #165

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Pact contract testing #165

merged 2 commits into from
Oct 20, 2022

Conversation

edeandrea
Copy link
Collaborator

Introduce pact contract testing

Closes #164

@edeandrea edeandrea mentioned this pull request Oct 18, 2022
Closed
@edeandrea edeandrea self-assigned this Oct 19, 2022
@edeandrea edeandrea added fights-service Fights service villains-service Villains service heroes-service Heroes service labels Oct 19, 2022
@edeandrea
Copy link
Collaborator Author

edeandrea commented Oct 19, 2022 •
edited
Loading

@holly-cummins I updated the commit for the PR based on what we discussed in this comment.

Would you mind reviewing? I added documentation as well as updates to the CI process (so that the consumer & provider tests run during the CI), so please review that too :)

@edeandrea
Copy link
Collaborator Author

I also added <pact_do_not_track>true</pact_do_not_track> to the surefire setup because I didn't think that https://docs.pact.io/telemetry was something we wanted enabled. Seems its enabled by default and you have to opt out of it.

@edeandrea edeandrea merged commit 45afa9a into quarkusio:main Oct 20, 2022
@edeandrea edeandrea deleted the pact-2 branch October 20, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holly-cummins holly-cummins holly-cummins approved these changes

Assignees

@edeandrea edeandrea

Labels
fights-service Fights service heroes-service Heroes service villains-service Villains service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Pact contract tests
2 participants
@edeandrea @holly-cummins