Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apicurio json schema kafka quickstart #1361

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Apicurio json schema kafka quickstart #1361

merged 2 commits into from
Jan 7, 2024

Conversation

carlesarnal
Copy link
Contributor

@carlesarnal carlesarnal commented Dec 18, 2023 •
edited
Loading

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

Depends on quarkusio/quarkus#37722, so marking as draft for now.

@carlesarnal carlesarnal changed the base branch from main to development December 18, 2023 19:23
@carlesarnal carlesarnal changed the base branch from development to main December 18, 2023 19:23
@carlesarnal carlesarnal mentioned this pull request Dec 21, 2023
Open
@carlesarnal carlesarnal marked this pull request as ready for review December 26, 2023 08:46
@carlesarnal
Copy link
Contributor Author

@cescoffier this is ready for review as well.

@cescoffier cescoffier merged commit 2fc37df into quarkusio:main Jan 7, 2024
gsmet added a commit that referenced this pull request Jan 11, 2024
@gsmet
Revert "Merge pull request #1361 from carlesarnal/json-schema-kafka-q…
aa67d02 
…uickstart"

This reverts commit 2fc37df, reversing
changes made to f93d5e4.
@gsmet
Copy link
Member

gsmet commented Jan 11, 2024

I had to revert this PR as it was targeting main and it messed up with the release.

Please resubmit the PR targeting development as the check list is asking for.

Thanks!

This was referenced Apr 17, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlesarnal @gsmet @cescoffier