Skip to content

Commit

Permalink
Only consider Java files for the star imports banning rule
Browse files Browse the repository at this point in the history
  • Loading branch information
gsmet committed Aug 3, 2021
1 parent 6c80fcc commit 168ebbd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-pr-development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
key: q2maven-pr-jdk-${{ matrix.java }}-${{ steps.get-date.outputs.date }}
- name: Check Wildcards
run: |
if [ $(git grep import | grep '\*;' | grep -E -v '(.mvn/|README.md|CONTRIBUTING.md)' | wc -l) != 0 ]; then
if [ $(git grep import -- '*.java' | grep '\*;' | grep -E -v '(.mvn/|README.md|CONTRIBUTING.md)' | wc -l) != 0 ]; then
echo "Please don't use star imports in your Java files: "
git grep import | grep '\*;' | grep -E -v '(.mvn/|README.md|CONTRIBUTING.md)'
exit 1
Expand Down

0 comments on commit 168ebbd

Please sign in to comment.