Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets - Rename Microservice with database to REST service #1502

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Presets - Rename Microservice with database to REST service #1502

merged 2 commits into from
Sep 26, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 26, 2024

No description provided.

@gsmet
Copy link
Member Author

gsmet commented Sep 26, 2024

I added another commit to reorganize things a bit and fix the legacy REST service preset.

I had a test failure in:

[ERROR]   CodeQuarkusPlaywrightTest.testSearchFilters:165 
expected: "origin:other"
 but was: ""

but looking at the test, I'm not sure it's related to my changes?

ia3andy
ia3andy approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet
Copy link
Member Author

gsmet commented Sep 26, 2024

I checked the UI locally and it looks good AFAICS.

@ia3andy ia3andy merged commit caa2ca2 into quarkusio:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsmet @ia3andy