Fix daily runs: Adapt to the new format of Prometheus metrics #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedinskiy
force-pushed
the
fix/prometheus-format
branch
from
c84d433 to
2bf6b28
Compare
|
Commit message is so vague, this can't go in - c'mon, some context needs to be in the message otherwise we have just row of "Fix error in daily runs" commits |
pjgg
suggested changes
Jan 13, 2023
Starting from Quarkus 2.16, the trailing comma was dropped from Prometheus metrics This change either allows tests to use both options, or disables them on older Quarkus versions. See quarkusio/quarkus#30343 for details
fedinskiy
force-pushed
the
fix/prometheus-format
branch
from
2bf6b28 to
9cf1fa2
Compare
pjgg
changed the title
pjgg
approved these changes
Jan 13, 2023
| @@ -22,7 +22,13 @@ public class HttpServerMetricsIT { | |||
| private static final int ASSERT_METRICS_TIMEOUT_MINUTES = 1; | |||
| private static final List<String> HTTP_SERVER_REQUESTS_METRICS_SUFFIX = Arrays.asList("count", "sum", "max"); | |||
|
|
|||
| private static final String HTTP_SERVER_REQUESTS_METRICS_FORMAT = "http_server_requests_seconds_%s{method=\"GET\",outcome=\"SUCCESS\",status=\"200\",uri=\"%s\",}"; | |||
| /* | |||
| * In versions before 2.16 metrics have format '{a,b,}' (with trailing comma) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See quarkusio/quarkus#30343 for details
Summary
Please select the relevant options.
run testsphrase in comment)Checklist: