Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not support any Origin by default if CORS is enabled #963

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Do not support any Origin by default if CORS is enabled #963

merged 1 commit into from
Dec 23, 2022

Conversation

afalhambra
Copy link
Contributor

@afalhambra afalhambra commented Dec 23, 2022 •
edited
Loading

Summary

As part of quarkusio/quarkus#29692, since no "origin" is longer supported out of the box by quarkus, we need to specifically mentioned this in our TS, by using quarkus.http.cors.origins property

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik mentioned this pull request Dec 23, 2022
Merged
9 tasks
michalvavrik
michalvavrik approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably be more specific than wildcard, but I'm pretty sure we will have dedicated TD for CORS, so let's go with this. I'll trigger OC runs just to be sure.

@michalvavrik
Copy link
Member

run tests

@afalhambra
Copy link
Contributor Author

All green, merging

@afalhambra afalhambra merged commit eb2fd35 into quarkus-qe:main Dec 23, 2022
@afalhambra afalhambra deleted the add-cors-wildcard branch December 23, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afalhambra @michalvavrik