Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fully-qualified names of docker images #611

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Use fully-qualified names of docker images #611

merged 1 commit into from
Apr 25, 2022

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Apr 22, 2022 •
edited
Loading

Summary

Required to solve porblems with podman and windows.
See testcontainers/testcontainers-java#5275
for details

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Use fully-qualified names of docker images
3a793bc 
Required to solve porblems with podman and windows.
See testcontainers/testcontainers-java#5275
for details
@fedinskiy fedinskiy requested a review from mjurc April 22, 2022 10:38
pjgg
pjgg approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedinskiy fedinskiy merged commit 24f1afa into quarkus-qe:main Apr 25, 2022
@fedinskiy fedinskiy deleted the fix/prod branch April 25, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedinskiy @pjgg @mjurc