Fix "unexpected end of stream" error. #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check that MariaDB container started, by looking into log and waiting for special lines. Before that change, we were looking for a line "ready for connections", which was duplicated and its first appearance was right before a reload of the container, so in some cases we were trying to connect to non-working DBMS. Now we use a unique line.
|
This is similar to the change made for sql-app in this MR: #599 |
|
Second commit is a fix for issue, described here: bitnami-labs/sealed-secrets#822 |
pjgg
suggested changes
Apr 21, 2022
README.md
Outdated
| - MSSQL: `mcr.microsoft.com/mssql/rhel/server` | ||
| - Oracle | ||
| - version 18c XE: `gvenzl/oracle-xe:18.4.0-slim` | ||
| - version 18c XE: `gvenzl/oracle-xe:21-slim` |
There was a problem hiding this comment.
why does this oracle version need to be changed?
There was a problem hiding this comment.
To reflect this change[1] made in January.
95313bb#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R209
2 tasks
pjgg
approved these changes
Apr 21, 2022
mjurc
requested changes
Apr 21, 2022
...pplications/src/test/java/io/quarkus/ts/external/applications/OpenShiftWorkshopHeroesIT.java
Show resolved
Hide resolved
...lications/src/test/java/io/quarkus/ts/external/applications/OpenShiftWorkshopVillainsIT.java
Show resolved
Hide resolved
mjurc
requested changes
Apr 21, 2022
Until 21.04.2022 we used quay.io/bitnami images to circumvent docker pull limit. Unforunately, Bitnami deleted all their quay.io images on the 20th of April, so now we use Docker hub and cashing proxy.
mjurc
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check that MariaDB container started, by looking into log and waiting
for special lines. Before that change, we were looking for a line "ready for connections",
which was duplicated and its first appearance was right before a reload
of the container, so in some cases we were trying to connect to
non-working DBMS. Now we use a unique line.
Summary
(Summarize the problem solved by this PR, and how to verify it manually)
Please select the relevant options.
Checklist: