-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactive MS SQL client support #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, rebase your PR.
sql-db/vertx-sql/src/test/java/io/quarkus/qe/vertx/sql/dbpool/PostgresPoolIT.java
Outdated
Show resolved
Hide resolved
sql-db/vertx-sql/src/test/java/io/quarkus/qe/vertx/sql/handlers/Db2HandlerIT.java
Outdated
Show resolved
Hide resolved
sql-db/vertx-sql/src/test/java/io/quarkus/qe/vertx/sql/handlers/MSsqlHandlerIT.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment to add ++ please rebase your BR, at the moment, it cannot be merged because there are conflicts.
run tests |
OCP are not working due to:
|
@fedinskiy please backport it to 2.2 |
* +Removed unneeded parameters * ~Test moved to integration tests * +Coverage for MS SQL; support for not using database in SQL requests * +Support of new API * +Full coverage of MS SQL * ~Refactoring * +Temporary fix * ~Format
* +Removed unneeded parameters * ~Test moved to integration tests * +Coverage for MS SQL; support for not using database in SQL requests * +Support of new API * +Full coverage of MS SQL * ~Refactoring * +Temporary fix * ~Format
* +Removed unneeded parameters * ~Test moved to integration tests * +Coverage for MS SQL; support for not using database in SQL requests * +Support of new API * +Full coverage of MS SQL * ~Refactoring * +Temporary fix * ~Format
Reactive MS SQL client support as tech preview. Part of QUARKUS-1081
Commits will be squashed before or during the merge