-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build-time analytics module execution failure as we should only set QE FW test properties in the test properties #2293
Conversation
Sorry, I haven't seen failures as I had cached page result, I need to inspect them first. |
f3875a4
to
b49baf7
Compare
b49baf7
to
3288975
Compare
I think the property has to be global, so service scope won't cut it. I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
thanks, yeah, I think CLI takes application properties from a different file or source. I had to go so I pushed it to see CI, I'll just find where CI is taking app properties from and fix it. |
I think either we stop relying on global scope and use service context for the property lookup, or we need to set system property and it still will be just a trick. I'll provide a FW PR and once we agree on solution, I'll update this one. |
thanks, but there will be changes
3288975
to
f90e046
Compare
hey @fedinskiy , thanks for the first review. Now CI is green, let's have a look. Thanks |
Summary
As result of the quarkus-qe/quarkus-test-framework#791 we expect that all QE FW properties are listed as enum constants in
Property
, however in past it was possible to set also Quarkus properties asts.global
, which now results in failure. Due to this issue, daily build fails https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/13111089359/job/36575004262 over[ERROR] java.util.ServiceConfigurationError: org.junit.platform.launcher.TestExecutionListener: Provider io.quarkus.test.listener.QuarkusTestResourceCleaningFilter could not be instantiated
. I have debugged it and found out that everytimenew PropertyLookup
constructor is instantiated in this module, loading of the global configuration fails as no such element.This is expected to fail until quarkus-qe/quarkus-test-framework#1485 is merged and this PR CI is re-run.
Please select the relevant options.
run tests
phrase in comment)Checklist: