Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use test FW snapshot by default #2224

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Use test FW snapshot by default #2224

merged 1 commit into from
Nov 29, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 27, 2024

Summary

This PR follows quarkus-qe/quarkus-test-framework#1418

Changes the default quarkus test framework version to daily snapshot. This should affect all jobs, that tests against main branch.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from mjurc November 27, 2024 13:38
@mocenas mocenas marked this pull request as draft November 27, 2024 13:38
@mocenas mocenas marked this pull request as ready for review November 29, 2024 11:00
mjurc
mjurc approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per what we agreed, @michalvavrik wanna chime in perhaps before we press merge?

michalvavrik
michalvavrik approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michalvavrik michalvavrik merged commit 883ebe1 into quarkus-qe:main Nov 29, 2024
13 checks passed
@michalvavrik
Copy link
Member

I just mentioned that you didn't run OCP, but I guess we will see in the periodic jobs, I think changes are OK.

@mocenas mocenas deleted the use_snapshot_framework branch December 2, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mocenas @michalvavrik @mjurc