Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove property JAVA_OPT_KC_HEAP #2154

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jcarranzan
Copy link
Contributor

Summary

As we discussed in this fix: quarkus-qe/quarkus-test-framework#1389
It is not already necessary to have this property JAVA_OPT_KC_HEAP for KeycloakService

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan requested a review from jedla97 October 31, 2024 15:44
@jcarranzan jcarranzan marked this pull request as ready for review October 31, 2024 15:47
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine by me.

Just if I understand corretly the new version of framework is needed and also shouldn't be openshit tests run?

I think this can wait to Monday to be rebased after the FW bump is merged + for failing test I don't think it caused by this but with new run after rebase we will see.

@jedla97
Copy link
Member

jedla97 commented Nov 4, 2024

@jcarranzan the FW version was updated, please rebase your PR so it include it.

@jcarranzan jcarranzan force-pushed the remove-property-keycloak branch from 24f2eb9 to 03d653e Compare November 4, 2024 08:17
@jcarranzan
Copy link
Contributor Author

run tests

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebase, let's see the CI

@jedla97
Copy link
Member

jedla97 commented Nov 4, 2024

run tests

@jedla97 jedla97 merged commit 69c04c2 into quarkus-qe:main Nov 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants