Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust expectations regarding OpenTelemetry JDBC operation names after Hibernate ORM bump to 6.5 #1783

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented May 6, 2024

Summary

After quarkusio/quarkus#40102 actual DB query changes as now, during the UPDATE with JDBC MSSQL, the alias is used. The DB statement now looks like this: update ae1_0 set amount=?,updatedAt=? from account ae1_0 where ae1_0.accountNumber=? which results in alias being used instead of database name.

I could not find anything in OTel specs in this regards, the closes I got is the first link open-telemetry/opentelemetry-java-instrumentation#7821, but it seems like a grey area and I don't think it's a bug.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from fedinskiy May 6, 2024 11:21
@fedinskiy fedinskiy merged commit f52e86b into quarkus-qe:main May 6, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-narayana-otel-traces branch May 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants