Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RESTEasy Reactive JAX-RS scenario #178

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Add RESTEasy Reactive JAX-RS scenario #178

merged 2 commits into from
Aug 26, 2021

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Aug 15, 2021 •
edited
Loading

Add http/jaxrs-reactive, which is a RESTEasy reactive equivalent of
http/jaxrs.
Notable differences and limitations:

  • In a multipart POJO, Java type for image and octet-stream were
    changed from InputStream to File - InputStream is not supported
    by resteasy-reactive.

@jsmrcka jsmrcka requested review from pjgg and kshpak August 15, 2021 17:28
@jsmrcka jsmrcka force-pushed the resteasy-reactive branch 2 times, most recently from 0eda225 to 13019ca Compare August 16, 2021 15:55
@rsvoboda
Copy link
Member

@jsmrcka there are failures in CI, please check and fix

Changing default charset (other than UTF-8) for multipart requests is not supported inquarkus-resteasy-reactive.

Is this known / documented limitation? If not, it should be mentioned in the upstream resteasy-reactive guide.

@jsmrcka jsmrcka force-pushed the resteasy-reactive branch from 13019ca to 01d894d Compare August 19, 2021 09:53
@kshpak
Copy link
Contributor

kshpak commented Aug 20, 2021

@jsmrcka can you squash the commits pls

@jsmrcka jsmrcka marked this pull request as draft August 20, 2021 11:29
@jsmrcka jsmrcka force-pushed the resteasy-reactive branch 2 times, most recently from 808a13a to c2eccd7 Compare August 20, 2021 12:10
@jsmrcka jsmrcka changed the title Add RESTEasy reactive JAX-RS scenario Add RESTEasy Reactive JAX-RS scenario Aug 20, 2021
@jsmrcka jsmrcka force-pushed the resteasy-reactive branch from c2eccd7 to 9f03526 Compare August 20, 2021 12:22
@jsmrcka jsmrcka marked this pull request as ready for review August 20, 2021 12:23
@jsmrcka jsmrcka force-pushed the resteasy-reactive branch 2 times, most recently from 7d0a2c6 to 7740fa4 Compare August 25, 2021 12:08
@jsmrcka jsmrcka requested a review from Sgitario August 25, 2021 12:09
@Sgitario
Copy link
Contributor

run tests

jsmrcka added 2 commits August 25, 2021 17:16
@jsmrcka
Add RESTEasy Reactive JAX-RS scenario
4c2b1bf 
Add `http/jaxrs-reactive`, which is a RESTEasy reactive equivalent of
`http/jaxrs`.
Notable differences and limitations:
- In a multipart POJO, Java type for `image` and `octet-stream` were
  changed from `InputStream` to `File` - `InputStream` is not supported
  by `resteasy-reactive`.
@jsmrcka
Fix broken formatting
ed5916e
@jsmrcka jsmrcka force-pushed the resteasy-reactive branch from 7740fa4 to ed5916e Compare August 25, 2021 16:49
@jsmrcka
Copy link
Contributor Author

jsmrcka commented Aug 25, 2021

run tests

@Sgitario
Copy link
Contributor

The JVM failure is caused by a port conflict.
The OpenShift JVM failures are caused by the OCP instance does not work well Status 500: {"message":"Head \"https://registry.redhat.io/v2/rhscl/mariadb-103-rhel7/manifests/latest\": unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication" cc @mjurc
Some OpenShift Native failures are caused by a too low xmx value (I will increase it to 5g).

Approving

@jsmrcka
Copy link
Contributor Author

jsmrcka commented Aug 26, 2021

I'm going to merge, I have a follow-up PR that needs this one.
@pjgg @kshpak If you have any comments, let me know and we resolve them separately.

@jsmrcka jsmrcka merged commit 8eb4b9e into quarkus-qe:main Aug 26, 2021
@jsmrcka jsmrcka deleted the resteasy-reactive branch August 26, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

@pjgg pjgg Awaiting requested review from pjgg

@kshpak kshpak Awaiting requested review from kshpak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsmrcka @rsvoboda @kshpak @Sgitario