Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Do not expect index page in DEV mode on Windows #1759

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 22, 2024

Summary

The check in question returns 404 on Windows due to quarkusio/quarkus#39909 (comment). It seems like it's related to the CLI version installed on our Windows runners with a Docker. I didn't look further into cause of this behavior because I do not consider this very important as long as there is opened known issue marked as won't f i x quarkusio/quarkus#39909.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from jedla97 April 22, 2024 20:14
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR and some investigation!

We should probably look into this when there will be more time as what I remeber codestart.quarkus put blank page even on linux and I would expect the same with cli. I'll create task for this

@jedla97 jedla97 merged commit fcbb92e into quarkus-qe:3.8 Apr 22, 2024
7 checks passed
@michalvavrik
Copy link
Member Author

We should probably look into this when there will be more time as what I remeber codestart.quarkus put blank page even on linux and I would expect the same with cli. I'll create task for this

true, it will need proper analysis, thanks

@michalvavrik michalvavrik deleted the feature-3-8/fix-cli-index-check branch April 22, 2024 21:39
mocenas added a commit that referenced this pull request Jun 27, 2024
michalvavrik pushed a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants