Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties module by removing the Person field #161

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Aug 9, 2021

Quarkus upstream upgraded SmallRye Config to 2.4.3 and it seems that there is no longer possible to use the annotation @ConfigMapping on classes, only in interfaces.
As we're already covering the interface mapping, I removed the field coverage.
Related issue: quarkusio/quarkus#19298

Quarkus upstream upgraded SmallRye Config to 2.4.3 and it seems that there is no longer possible to use the annotation @ConfigMapping on classes, only in interfaces.
As we're already covering the interface mapping, I removed the field coverage.
Related issue: quarkusio/quarkus#19298
@Sgitario Sgitario requested a review from kshpak August 9, 2021 11:35
@Sgitario
Copy link
Contributor Author

Sgitario commented Aug 9, 2021

Similar to quarkus-qe/beefy-scenarios#246

@kshpak kshpak merged commit fb94c3a into quarkus-qe:main Aug 9, 2021
@Sgitario Sgitario deleted the fix_person_interface branch August 9, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants