Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for grpc GlobalInterceptor method annotation #1531

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Nov 20, 2023

Summary

Add test coverage for quarkusio/quarkus#21358. Testing both server and client interceptor.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Nov 20, 2023

run tests

@jedla97 jedla97 requested a review from michalvavrik November 20, 2023 07:49
@jedla97 jedla97 force-pushed the grpc-global-interceptor branch from 2737599 to 12077e9 Compare November 20, 2023 10:25
@jedla97
Copy link
Member Author

jedla97 commented Nov 20, 2023

run tests

@michalvavrik michalvavrik added the triage/backport-3.2 RHBQ Ghost LTS release label Nov 20, 2023
@jedla97 jedla97 force-pushed the grpc-global-interceptor branch 2 times, most recently from cd1d738 to 393fa6b Compare November 21, 2023 18:00
@jedla97 jedla97 force-pushed the grpc-global-interceptor branch from 393fa6b to 64a9b5d Compare November 21, 2023 18:07
@jedla97
Copy link
Member Author

jedla97 commented Nov 21, 2023

Updated it with more realistic usecase. And adding tag to RH Quarkus jira.

Now it's workflow intercept client -> intercept server -> server read added header by client -> server add to Context -> context is propagated to service.

This testing global interceptor for class and methods which each intercepted call (method and class) have own constant used to pass client intercepted data to next step.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good research, nice job.

@michalvavrik michalvavrik merged commit 65089ef into quarkus-qe:main Nov 21, 2023
7 checks passed
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Nov 23, 2023
@jedla97 jedla97 deleted the grpc-global-interceptor branch December 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants