Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove todo with resolved issue from pom - Docker image naming strategy #1307

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Remove todo with resolved issue from pom - Docker image naming strategy #1307

merged 1 commit into from
Jul 8, 2023

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Jul 8, 2023

Summary

Issue was #609 was closed.
Docker image naming strategy is clear and documented.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested a review from michalvavrik July 8, 2023 16:21
michalvavrik
michalvavrik approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 25844d7 into quarkus-qe:main Jul 8, 2023
@gtroitsk gtroitsk deleted the naming-strategy-docker-issue branch July 13, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik