Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing comma is no longer present in Micrometer Prometheus #1241

Merged
merged 1 commit into from
May 25, 2023
Merged

Trailing comma is no longer present in Micrometer Prometheus #1241

merged 1 commit into from
May 25, 2023

Conversation

gtroitsk
Copy link
Member

Summary

Micrometer Prometheus now uses new format without trailing comma.
quarkusio/quarkus#30343

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested review from fedinskiy and michalvavrik and removed request for fedinskiy May 25, 2023 09:04
michalvavrik
michalvavrik approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michalvavrik
michalvavrik approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 987e1b6 into quarkus-qe:main May 25, 2023
@gtroitsk gtroitsk deleted the metrics-format branch May 30, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik