Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PG service binding tests as upstream issue is fixed #1164

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 11, 2023

Summary

closes: #993

According to quarkusio/quarkus#32773 (comment) the issue was fixed by quarkusio/quarkus#32651.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik changed the title Enable PG service binding tests as upstream issue is fixed WIP Enable PG service binding tests as upstream issue is fixed Apr 11, 2023
@michalvavrik michalvavrik force-pushed the feature/enable-pg-oc-test branch from 04b43c4 to aed3140 Compare April 20, 2023 08:57
@michalvavrik michalvavrik changed the title WIP Enable PG service binding tests as upstream issue is fixed Enable PG service binding tests as upstream issue is fixed Apr 20, 2023
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

run tests

1 similar comment
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from mjurc April 21, 2023 13:26
@michalvavrik michalvavrik marked this pull request as ready for review April 21, 2023 13:28
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with regards to reading the issue histroy. At the same time, this is regression in usability compared to 2.2 even.

SB is tech preview, but still. I'll merge for now, but we should follow up with product issue.

@mjurc mjurc merged commit 8b702fe into quarkus-qe:main Apr 21, 2023
@michalvavrik michalvavrik deleted the feature/enable-pg-oc-test branch April 21, 2023 13:49
@rsvoboda
Copy link
Member

rsvoboda commented Apr 21, 2023

we should follow up with product issue.

+1 ... Is this future 3.2 release related or it affects also next 2.13.z ?

Update: I see #1187, so this is probably no longer relevant question.

@michalvavrik
Copy link
Member Author

no regression, not sure why it didn't work with hippo prev, but it does now #1187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShiftPostgreSqlReactiveSbIT robustly fails
3 participants