-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PG service binding tests as upstream issue is fixed #1164
Conversation
run tests |
04b43c4
to
aed3140
Compare
run tests |
aed3140
to
9084d69
Compare
run tests |
1 similar comment
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with regards to reading the issue histroy. At the same time, this is regression in usability compared to 2.2 even.
SB is tech preview, but still. I'll merge for now, but we should follow up with product issue.
+1 ... Is this future 3.2 release related or it affects also next 2.13.z ? Update: I see #1187, so this is probably no longer relevant question. |
no regression, not sure why it didn't work with hippo prev, but it does now #1187 |
Summary
closes: #993
According to quarkusio/quarkus#32773 (comment) the issue was fixed by quarkusio/quarkus#32651.
hippo
->postgresql
: it doesn't work with hippo, I think that's because the name is also used for named datasource (so it looks for hippo ds), it is documented at the very end of this page https://quarkus.io/guides/deploying-to-kubernetes#customizing-automatic-service-binding (full disclosure: I'm not sure here. Do you read it same way I do?)Please select the relevant options.
run tests
phrase in comment)Checklist: