Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Quarkus CLI tests as upstream issue is now fixed #1136

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Enable Quarkus CLI tests as upstream issue is now fixed #1136

merged 1 commit into from
Mar 30, 2023

Conversation

michalvavrik
Copy link
Member

Summary

quarkusio/quarkus#32219 is fixed.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda self-requested a review March 30, 2023 09:28
@michalvavrik
Copy link
Member Author

QuarkusCliCreateJvmApplicationIT.shouldAddAndRemoveExtensions is not flaky, I re-run it and still failed. Will investigate now.

@michalvavrik
Copy link
Member Author

Opened issue quarkusio/quarkus#32266, I'll disable test. We can enable it later.

@michalvavrik michalvavrik force-pushed the feature/enable-cli-tests branch from 666d1df to 9a216d9 Compare March 30, 2023 11:15
@michalvavrik michalvavrik merged commit 51ba9c6 into quarkus-qe:main Mar 30, 2023
@michalvavrik michalvavrik deleted the feature/enable-cli-tests branch March 30, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @rsvoboda