Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OCP secrets with destination mount path #993

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 19, 2023

Summary

From user POV it's same as we already support for resources (config maps), I just wrote it slightly differently. Keycloak image has only certain dirs writable so I need to specify destination, but for certs can't use config maps as binary data needs to be base64 encoded as secrets do. I've tested it on what I am preparing for mTLS OIDC test (not that I'm done, but Keycloak starts with keystores and truststores).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

GH CI failures go down to the #991, luckily this PR changes can affect only OCP and nothing else. Let's pay attention to OCP CI please.

@michalvavrik michalvavrik requested a review from jedla97 December 19, 2023 19:10
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looking at CI all is green so merging.

@jedla97 jedla97 merged commit 2e6500d into quarkus-qe:main Dec 19, 2023
9 checks passed
@michalvavrik michalvavrik deleted the feature/ocp-secrets-with-destination branch December 19, 2023 20:10
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants