Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests affected by quarkus issue 35288 #856

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Disable tests affected by quarkus issue 35288 #856

merged 1 commit into from
Aug 9, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Aug 9, 2023

Summary

Disable tests affected by quarkus/35288. As this only disable tests I don't think it's needed to run Openshift test. Also It will be run with 3.2.3.Final where this issue not appearing.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 requested a review from mjurc August 9, 2023 14:57
mjurc
mjurc requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports need to be ordered properly. Otherwise, LGTM.

...java/io/quarkus/qe/OpenShiftUsingExtensionAndDockerBuildAndServerlessPingPongResourceIT.java Outdated
@@ -2,7 +2,9 @@

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;
import org.junit.jupiter.api.Disabled;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is out of order.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I didn't check this beforehand.

...pong/src/test/java/io/quarkus/qe/OpenShiftUsingExtensionAndServerlessPingPongResourceIT.java Outdated
@@ -2,7 +2,9 @@

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;
import org.junit.jupiter.api.Disabled;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is out of order.

@jedla97 jedla97 force-pushed the disable-test-affected-35288 branch from f9818f5 to 41b20d4 Compare August 9, 2023 16:49
mjurc
mjurc approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mjurc mjurc merged commit d7d0dd3 into quarkus-qe:main Aug 9, 2023
@michalvavrik michalvavrik mentioned this pull request Aug 29, 2023
Merged
11 tasks
@jedla97 jedla97 deleted the disable-test-affected-35288 branch April 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @mjurc