Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Quarkus Maven plugin issue with resolving local deps #835

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jul 17, 2023

Summary

See quarkusio/quarkus#34787 (comment).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/workaround-ws-loader-missing-profiles-issue branch from 3587748 to a30abc0 Compare July 17, 2023 13:40
@michalvavrik michalvavrik requested a review from fedinskiy July 17, 2023 13:53
@fedinskiy
Copy link
Contributor

Do other CIs affected? The daily one, for example?

@michalvavrik
Copy link
Member Author

michalvavrik commented Jul 17, 2023

Daily build is green, so I guess it does not. I won't pretend I understand this..

@michalvavrik
Copy link
Member Author

I don't think I can easily try release locally, tried mvn -B release:prepare -Prelease,framework,extensions,examples -DautoVersionSubmodules -s .github/mvn-settings.xml and it failed when building parent. Probably I need to know more about it, but TBH I'd rather spent time on it when I know there is an issue (e.g. release failed).

@michalvavrik michalvavrik merged commit 9666394 into quarkus-qe:main Jul 17, 2023
@michalvavrik michalvavrik deleted the feature/workaround-ws-loader-missing-profiles-issue branch July 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants