Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to wait until service is started #834

Merged

Conversation

michalvavrik
Copy link
Member

Summary

Our io.quarkus.test.bootstrap.BaseService#restart don't wait for started application, which is useful for Quarkus CLI tests that expects application to be unavailable right after restart, however I need to wait for restarted app when it crashed and I don't want to do it manually.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc July 15, 2023 16:30
@michalvavrik
Copy link
Member Author

Ouch! This validation failure is not related, we experienced it (or brought it in) in #831

/cc @fedinskiy

@michalvavrik
Copy link
Member Author

Could not transfer artifact io.quarkus.qe:quarkus-test-core:pom:1.3.1.Beta21-SNAPSHOT from/to gradle-official-repository (https://repo.gradle.org/gradle/libs-releases-local/

This is just super strange, why Gradle?

@michalvavrik michalvavrik force-pushed the feature/expose-wait-till-started-svc branch 3 times, most recently from 5deb906 to 9962a77 Compare July 15, 2023 17:54
@fedinskiy
Copy link
Contributor

@michalvavrik

  1. Why gradle: it is the last repo in the list. We also didn't find the artifact in jboss-maven-central-proxy and google-maven-central.
  2. If you've applied existing workarounds (full path to parent pom and new helm version), then the only option I see is to add building/installing of the framework before running validation. Or to create a bug for Quarkus guys, if you could make a sane reproducer

@michalvavrik michalvavrik force-pushed the feature/expose-wait-till-started-svc branch from 9962a77 to c5b8aa6 Compare July 19, 2023 09:49
@michalvavrik
Copy link
Member Author

ping @mjurc

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

@mjurc mjurc merged commit 6e5d631 into quarkus-qe:main Jul 19, 2023
@michalvavrik michalvavrik deleted the feature/expose-wait-till-started-svc branch July 19, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants