Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Quarkus native s2i configuration property #753

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Apr 21, 2023

Summary

Change Quarkus native s2i configuration property as quarkusio/quarkus#30829 issue was resolved.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested a review from michalvavrik April 21, 2023 12:53
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik
Copy link
Member

run tests

@michalvavrik
Copy link
Member

hmm, now I realized all the tests that uses it are disabled :-/ @gtroitsk we get this in when CI is green, but please base your other MR that enables QS tests on this PR (rebase them on main when this is merged)

@michalvavrik michalvavrik merged commit 0b01c5f into quarkus-qe:main Apr 21, 2023
@gtroitsk gtroitsk deleted the openshift-s2i-git-repo branch April 26, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants