Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenShift resource URI caching - clear cache on service stop #656

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix OpenShift resource URI caching - clear cache on service stop #656

merged 1 commit into from
Jan 23, 2023

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Jan 19, 2023

Summary

Prevents the cached value from distorting status checks on stopped resources.

This fixes infinispan-client failures observed in e.g. quarkus-qe/quarkus-test-suite#975.

This is a follow-up to
#625, which introduced the caching in order to fix issues in INTEROP environment. See e.g.
https://mpts-prod.psi.redhat.com/dashboard/run/?id=8896.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jsmrcka
Fix OpenShift resource URI caching - clear cache on service stop
f59e642 
Prevents the cached value from distorting status checks on stopped
resources.

This fixes `infinispan-client` failures observed in e.g.
quarkus-qe/quarkus-test-suite#975.

This is a follow-up to
quarkus-qe#625,
which introduced the caching in order to fix issues in INTEROP
environment. See e.g.
https://mpts-prod.psi.redhat.com/dashboard/run/?id=8896.
@jsmrcka jsmrcka requested review from pjgg and fedinskiy January 19, 2023 12:16
@jsmrcka jsmrcka self-assigned this Jan 19, 2023
@jsmrcka jsmrcka added the triage/backport-1.2? Backport to 1.2 branch may be required label Jan 19, 2023
@jsmrcka
Copy link
Contributor Author

jsmrcka commented Jan 19, 2023

run tests

pjgg
pjgg approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit 2f846ff into quarkus-qe:main Jan 23, 2023
@pjgg pjgg mentioned this pull request Jan 30, 2023
Merged
1 task
@jsmrcka jsmrcka deleted the fix/openshift-resource-uri-cache branch February 1, 2023 14:45
@jsmrcka jsmrcka mentioned this pull request Feb 1, 2023
Merged
10 tasks
@michalvavrik michalvavrik mentioned this pull request Feb 8, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

@fedinskiy fedinskiy Awaiting requested review from fedinskiy

Assignees

@jsmrcka jsmrcka

Labels
triage/backport-1.2? Backport to 1.2 branch may be required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsmrcka @pjgg