Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit definition of jsoup dependency #485

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Explicit definition of jsoup dependency #485

merged 1 commit into from
Jun 15, 2022

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jun 15, 2022

Summary

Explicit definition of jsoup dependency

Workaround for quarkiverse/quarkus-config-extensions#70

Checklist:

  • Example scenarios has been updated / added
  • Commits are well encapsulated and follow the best practices

@pjgg pjgg requested a review from rsvoboda June 15, 2022 07:46
rsvoboda
rsvoboda approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. First I was thinking that this should go into quarkus-test-service-consul module, but its just client side, not quarkus extension related.

@pjgg pjgg merged commit 32860e0 into quarkus-qe:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjgg @rsvoboda