Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate log files for CLI commands and CLI dev mode, and clean the files at the end #478

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jun 1, 2022

Use separate log files for CLI commands and CLI dev mode, and clean the files at the end

Fixes #477

Run QuarkusCliClientIT from examples to see the difference before the fix and with the fix.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda requested a review from mjurc June 1, 2022 11:04
@rsvoboda rsvoboda added the triage/backport-1.1? Backport to 1.1 branch may be required label Jun 1, 2022
@mjurc
Copy link
Member

mjurc commented Jun 1, 2022

PR LGTM, but it fails validation:

Error:  Failed to execute goal net.revelc.code:impsort-maven-plugin:1.7.0:check (default) on project quarkus-test-cli: Imports are not sorted in /home/runner/work/quarkus-test-framework/quarkus-test-framework/quarkus-test-cli/src/main/java/io/quarkus/test/services/quarkus/CliDevModeLocalhostQuarkusApplicationManagedResource.java -> [Help 1]

This needs to be fixed first.

@rsvoboda rsvoboda force-pushed the fix.cli.log.messages branch from a23a15e to 89c502f Compare June 1, 2022 11:58
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjurc mjurc merged commit 936115d into quarkus-qe:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/backport-1.1? Backport to 1.1 branch may be required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate log output for chain of CLI commands
2 participants