Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate examples profile during release preparation #1435

Merged

Conversation

michalvavrik
Copy link
Member

Summary

I dropped this yesterday https://github.com/quarkus-qe/quarkus-test-framework/pull/1431/files because AFAICT there is no reason to prepare examples. However release fails https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/12291828284/job/34309866608 and this change is one of few ideas I have for why it fails.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik merged commit 2af62f5 into quarkus-qe:main Dec 12, 2024
0 of 6 checks passed
@michalvavrik michalvavrik deleted the feature/fix-release-workflow-1 branch December 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant