Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily deploy snapshot - change deploy plugin. #1422

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 28, 2024

Summary

Follows up on #1418.

Fix problems with both daily and release workflows.

Daily was failing on singing, because propagating GPG PASSPHRASE to maven env was missing.

Release was failing, because release workflow has wrong serverId. Server ID in the workflow (which workflow sets up the credentials for) should match the one in pom.xml. I wonder that this worked before.

Also splitting the pom profiles to have separate profile for snapshot and release deploy.
Current release deployement should be the same as before.
Snapshot deployement has successfully run here

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from mjurc November 28, 2024 10:44
@mocenas mocenas marked this pull request as draft November 28, 2024 10:58
@mocenas mocenas marked this pull request as ready for review November 28, 2024 11:52
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me, do you want to open a testing release PR again? :)

@mocenas
Copy link
Contributor Author

mocenas commented Nov 29, 2024

Looks fine by me, do you want to open a testing release PR again? :)

Sure I will open one

@mocenas mocenas merged commit ae3de03 into quarkus-qe:main Nov 29, 2024
7 checks passed
@mocenas mocenas mentioned this pull request Nov 29, 2024
11 tasks
@mocenas mocenas deleted the daily_release branch November 29, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants