Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.5.8 #1399

Merged
merged 1 commit into from
Nov 5, 2024
Merged

release 1.5.8 #1399

merged 1 commit into from
Nov 5, 2024

Conversation

jcarranzan
Copy link
Contributor

Summary

Release 1.5.8 as we need #1394 Fix the Keycloak on Podman

Release contains:

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan requested a review from jedla97 November 5, 2024 08:11
@jcarranzan jcarranzan marked this pull request as ready for review November 5, 2024 08:12
@jcarranzan jcarranzan requested a review from fedinskiy November 5, 2024 08:26
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtroitsk
Copy link
Member

gtroitsk commented Nov 5, 2024

@jcarranzan release check previously failed because of wrong tag (v1.5.8) on 1.6.0.Beta14 release, please be more careful next time

Copy link

github-actions bot commented Nov 5, 2024

Unknown format for flaky report filename: flaky-run-report.json
Following jobs contain at least one flaky test:

  • Linux - JVM build - Released Versions

Run summary: https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/11681188634?pr=1399

Flaky tests:


io.quarkus.qe.StrimziKafkaWithDefaultSaslSslMessagingIT.checkUserResourceByNormalUser

  • Failure message: Assertion condition defined as a Lambda expression in io.quarkus.qe.StrimziKafkaWithDefaultSaslSslMessagingIT 1 expectation failed. Expected status code <200> but was <204>. within 5 seconds.
  • Failed in jobs:
    • flaky-run-report.json
Failure stacktrace
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.qe.StrimziKafkaWithDefaultSaslSslMessagingIT 1 expectation failed.
Expected status code <200> but was <204>.
 within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.qe.StrimziKafkaWithDefaultSaslSslMessagingIT.checkUserResourceByNormalUser(StrimziKafkaWithDefaultSaslSslMessagingIT.java:30)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <204>.

	at java.base/jdk.internal.reflect.GeneratedConstructorAccessor70.newInstance(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
	at io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.validate(ResponseSpecificationImpl.groovy:512)
	at io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure$validate$1.call(Unknown Source)
	at io.restassured.internal.ResponseSpecificationImpl.validateResponseIfRequired(ResponseSpecificationImpl.groovy:696)
	at io.restassured.internal.ResponseSpecificationImpl.this$2$validateResponseIfRequired(ResponseSpecificationImpl.groovy)
	at jdk.internal.reflect.GeneratedMethodAccessor109.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.codehaus.groovy.runtime.callsite.PlainObjectMetaMethodSite.doInvoke(PlainObjectMetaMethodSite.java:43)
	at org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite$PogoCachedMethodSiteNoUnwrapNoCoerce.invoke(PogoMetaMethodSite.java:198)
	at org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite.callCurrent(PogoMetaMethodSite.java:62)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:185)
	at io.restassured.internal.ResponseSpecificationImpl.statusCode(ResponseSpecificationImpl.groovy:135)
	at io.restassured.specification.ResponseSpecification$statusCode$0.callCurrent(Unknown Source)
	at io.restassured.internal.ResponseSpecificationImpl.statusCode(ResponseSpecificationImpl.groovy:143)
	at io.restassured.internal.ValidatableResponseOptionsImpl.statusCode(ValidatableResponseOptionsImpl.java:89)
	at io.quarkus.qe.StrimziKafkaWithDefaultSaslSslMessagingIT.lambda$checkUserResourceByNormalUser$0(StrimziKafkaWithDefaultSaslSslMessagingIT.java:33)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)


@jcarranzan jcarranzan requested a review from jedla97 November 5, 2024 10:34
@jedla97 jedla97 merged commit eb34bcd into 1.5.z Nov 5, 2024
9 checks passed
@jedla97 jedla97 deleted the release/1.5.8 branch November 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants