Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings cleanup #1396

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Build warnings cleanup #1396

merged 2 commits into from
Nov 5, 2024

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Nov 4, 2024

Summary

  • Use systemPropertyVariables instead of deprecated systemProperties
  • Specify surefire version to avoid build warnings

Removes following warnings

[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.quarkus.qe:examples-quarkus-cli:jar:1.6.0.Beta15-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-surefire-plugin is missing. @ line 29, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
--
[INFO]
[INFO] --- failsafe:3.5.1:integration-test (default) @ examples-kafka ---
[WARNING]  Parameter 'systemProperties' is deprecated: Use systemPropertyVariables instead.
[INFO] Tests are skipped.
[INFO]
--

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda requested a review from jcarranzan November 4, 2024 15:17
Copy link
Contributor

@jcarranzan jcarranzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me the change to clean up the build warnings.
On the other hand, not sure if we also should tweak this kind of method that it's passed deprecated systemProperties:

public static List<String> devModeMavenCommand(ServiceContext serviceContext, List<String> systemProperties) {

@rsvoboda
Copy link
Member Author

rsvoboda commented Nov 5, 2024

@jcarranzan Please elaborate. System property is just named systemProperties, how does it relate to maven-failsafe-plugin configuration?

@jcarranzan
Copy link
Contributor

My comment was just as a question, when I reviewed your PR I did a quick search of systemProperties and I found the same coincidence name that it's used on MavenUtils.java class so I just wanted to ensure that we are not overlooking any areas where deprecated systemProperties might cause warnings, but looking again as you mentioned the systemProperties in MavenUtils is unrelated to your changes.
Thanks.

@rsvoboda
Copy link
Member Author

rsvoboda commented Nov 5, 2024

Cool. So it's good to merge.

@jcarranzan jcarranzan merged commit ece22d8 into quarkus-qe:main Nov 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants